Closes #316 (Was dropping rest of proof)

egraphs-good / egg

egg is a flexible, high-performance e-graph library

https://egraphs-good.github.io

MIT License

1.35k stars 136 forks source link

Closes #316 (Was dropping rest of proof) #317

Closed eytans closed 1 month ago

eytans commented 3 months ago

Added test for existance + fix bad connection choice and… bad drop of rest_if_proof

I think this is a full fix, but to be honest I am not sure exactly how everything works, so I hope I am not breaking anything. cargo test passes, and I did run make, but couldn't run with features="lp".

yihozhang commented 2 months ago

This PR seems to be overlooked... @oflatt maybe you could take a look?

oflatt commented 1 month ago

@eytans would love to merge this if you have time to fix a small conflict!

eytans commented 1 month ago

@oflatt Sure. You can merge now