Fix bug in sharing invariant via translation to Term and back again

egraphs-good / eggcc

MIT License

42 stars 8 forks source link

Fix bug in sharing invariant via translation to Term and back again #431

Closed oflatt closed 5 months ago

oflatt commented 5 months ago

The RVSDG->DAG pass wasn't maintaining the sharing invariant (that sub-terms that are equal must be shared using the same Rc poitner). This PR fixes that.

It also fixes up typechecking to do proper caching based on the argument type

oflatt commented 5 months ago

I think just the benchmark overlaps