egraphs-good / eggcc

MIT License
42 stars 8 forks source link

Fix state passthrough (banish the shadow realm) #622

Closed Alex-Fischman closed 3 months ago

Alex-Fischman commented 3 months ago

This PR fixes the state edge passthrough performance bug by "tying the knot" so that loop contexts point to the loop itself (instead of to the pre-context version of the loop). To this end, it also:

ajpal commented 3 months ago

I'd like to see a solid nightly run before we merge, but code lgtm!

Alex-Fischman commented 3 months ago

I just looked at eggcc-notify and the nightly for main has been failing since May 31st. Since I rebased my branch is also failing. I don't know why.

Alex-Fischman commented 3 months ago

Rebased on fix-install (#623).