Add power operator to i64 and f64 sorts

egraphs-good / egglog

egraphs + datalog!

https://egraphs-good.github.io/egglog/

MIT License

459 stars 54 forks source link

Closed DeLectionnes closed 3 months ago

DeLectionnes commented 3 months ago

After review of the i64 interface in https://doc.rust-lang.org/std/primitive.i64.html, it seems that all power functions take a u32 as exponent instead of another i64.

Should I use the unsafe proposition that the test suite proposes, or should I only leave the f64 part ?

saulshanabrook commented 3 months ago

Maybe just leave the f64 then, that seems easiest.

DeLectionnes commented 3 months ago

Is there a way to run the test suite on my branch ? it did not transfer when I forked.

saulshanabrook commented 3 months ago

@DeLectionnes If you go to the actions tab on your fork you should be able to re-enable github actions