search

egraphs-good / egglog

egraphs + datalog!
https://egraphs-good.github.io/egglog/
MIT License
458 stars 54 forks source link

Remove HIGH_COST #433

Closed Alex-Fischman closed 1 month ago

Alex-Fischman commented 1 month ago

This PR removes HIGH_COST for a few reasons:

  1. It's unused.
  2. It's buggy. On 32-bit systems (such as WASM?) i64::MAX will overflow.
  3. It's undocumented, so I don't believe it's used outside of this crate. If it is used outside of this crate, I'll edit the PR to use isize instead of i64 to fix the bug, and add documentation.