search

egraphs-good / egglog

egraphs + datalog!
https://egraphs-good.github.io/egglog/
MIT License
458 stars 54 forks source link

Update symbol_table #456

Closed thaliaarchi closed 3 weeks ago

thaliaarchi commented 3 weeks ago

Brings symbol_table to the same version of hashbrown as egglog and has multi-threaded performance improvements. Follows up on PR#445 Update hashbrown.

codspeed-hq[bot] commented 3 weeks ago

CodSpeed Performance Report

Merging #456 will degrade performances by 12.76%

Comparing thaliaarchi:update-symbol_table (3ffa03a) with main (60342af)

Summary

❌ 1 (👁 1) regressions ✅ 7 untouched benchmarks

Benchmarks breakdown

Benchmark main thaliaarchi:update-symbol_table Change
👁 cykjson 320 ms 366.8 ms -12.76%
thaliaarchi commented 3 weeks ago

Huh. cykjson seems to be very sensitive to hashing.

yihozhang commented 3 weeks ago

We saw regression on cykjson, but we think it is fine because this is just a dependency change and seems unavoidable. Also for context we are also considering removing symbol_table.