egraphs-good / egglog

egraphs + datalog!
https://egraphs-good.github.io/egglog/
MIT License
458 stars 54 forks source link

Disable build script for library builds #467

Closed DaniPopes closed 3 days ago

DaniPopes commented 1 week ago

The build script is only used for emitting the FULL_VERSION environment variable, which is only used in the binary. Make it a noop if "bin" is not enabled.

codspeed-hq[bot] commented 1 week ago

CodSpeed Performance Report

Merging #467 will not alter performance

Comparing DaniPopes:optional-build (1bcaef5) with main (ca52ac1)

Summary

✅ 8 untouched benchmarks

saulshanabrook commented 1 week ago

Is the main advantage of this that library builds don't need chrono?

DaniPopes commented 1 week ago

Yeah and that the build script won't do anything. Unfortunately I don't think there is a way to completely disable the build script, but we can make it do the least amount of work possible.