egraphs-good / egglog

egraphs + datalog!
https://egraphs-good.github.io/egglog/
MIT License
458 stars 54 forks source link

Store str instead of String in ParseError #469

Closed DaniPopes closed 1 week ago

DaniPopes commented 1 week ago

Minor performance improvement for the parser. In repeat_until_end_paren the Err is constructed and discarded immediately after, which allocated a string unnecessarily.

codspeed-hq[bot] commented 1 week ago

CodSpeed Performance Report

Merging #469 will not alter performance

Comparing DaniPopes:parse-error-string (4031ed9) with main (2c8d947)

Summary

✅ 8 untouched benchmarks