Open DaniPopes opened 1 week ago
Comparing DaniPopes:parser-map
(9c1663d) with main
(2c8d947)
✅ 8
untouched benchmarks
Thanks for the debugging around slow compile times , and for following up in an issue on rustc.
Sorry for the delayed response here. I agree with Alex. I think the added parse
methods probably outweigh the benefit of having map
being a method. I think it may be better to revert to map being a function.
Fixes https://github.com/egraphs-good/egglog/issues/468. I'm not sure why this works but it probably has something to do with return-position
impl Trait
in traits having some exponential behavior in rustc.Compile times for
cargo build --bin egglog
went from 40s to 8s on my machine, withegglog
(library) now taking about 3s.