:bug: Valid domains won't validate

egulias / EmailValidator4J

Java RFC strict EmailValidator

MIT License

25 stars 8 forks source link

:bug: Valid domains won't validate #11

Closed AlainODea closed 5 years ago

AlainODea commented 5 years ago

Allow valid domains with subdomains starting with numbers
Allow valid domains with hyphens

Resolves #10

AlainODea commented 5 years ago

@egulias if you get a chance to review this, I'd really appreciate it. I introduced a bad regression in the last release and it actually bit us in production. Sorry about that.

AlainODea commented 5 years ago

@egulias I think I have addressed your code review concerns and I'm happy to improve further as requested.

AlainODea commented 5 years ago

@egulias is this good to go? If I don't hear from you, I'll assume you are very busy and touch base next week.

AlainODea commented 5 years ago

@egulias any chance this can be reviewed and merged?

egulias commented 5 years ago

Hi @AlainODea , thanks for your patience. Yeas, busy weeks indeed. Merged. I'll do the release.

AlainODea commented 5 years ago

I sincerely appreciate this, @egulias. Thank you 😊