egzumer / uv-k5-firmware-custom

A merge between https://github.com/OneOfEleven/uv-k5-firmware-custom and https://github.com/fagci/uv-k5-firmware-fagci-mod
Apache License 2.0
1.23k stars 396 forks source link

bug: Something in FM Broadcast mode calling EEPROM_WriteBuffer() repeatedly #570

Closed prokrypt closed 2 months ago

prokrypt commented 4 months ago

I added blinking red LED into EEPROM_WriteBuffer() for shits and giggles, and discovered : 1) I inserted code to turn red LED on too early in the function, before the part that reads the EEPROM to determine if there are changes to write. 2) Because of that, I noticed this: when you turn on the FM Broadcast mode and change frequencies, it calls EEPROM_WriteBuffer() in some loop forever (red led basically remains on). However, it seems it returns each time after the EEPROM is read, so there is no danger of wearing out the EEPROM.

This isn't a major bug at all, but ideally it shouldn't happen.