eh158 / BME590_LED_Project

0 stars 0 forks source link

Milestone 4 Review #4

Open eh158 opened 5 years ago

eh158 commented 5 years ago

Addressed feedback from Dr. Palmeri. The original circuit was based essentially off the circuit that was done in class; I tried to address the missing components that you mentioned and also removed the diodes that I thought were supposed to offer voltage protection to the pins. On the software side, my apologies for not having that up earlier; I planned my code in a very similar structure to the code shown in class. The only major difference is that I wanted to set the PWM state only after the button was pressed.

sphaerobolus commented 5 years ago

The schematic I find in the repo seems to be corrupt. I can view the board. All comments below are based on the board.

You'll want thicker traces. 6mil is no good for our photo-etch process. 12mil is better, 20mil better still.

You don't need a voltage regulator if you're using the Uno. The Uno has a regulator and you can take advantage of that. Your 9V goes into the Vin pin. Then you have 5V available from the Uno board on its 5V pin.

Be careful using pin 0 as a general i/o pin, as it is used for other things, too. It's possible to use it, but sometimes it's better (ok, lazier) to just avoid 0 and 1.

sphaerobolus commented 5 years ago

oh, yeah. you'll also ingratiate yourself with the TAs and me if you reduce the size of your board to just a shield. You can move all the components inside the perimeter. There's no "keep out" between the headers, so go ahead and use that space.

eh158 commented 5 years ago

OK thank you! I will try to incorporate all of this and upload a new version tomorrow night that is (hopefully) not corrupted