search

ehcache / ehcache-jcache

The Ehcache 2.x implementation of JSR107 (JCACHE)
Other
91 stars 48 forks source link

When configured to storeByValue, keys should be stored by value #3

Closed ryangardner closed 12 years ago

ryangardner commented 13 years ago

Currently the StoreByValueTest#get_existing_MutateKey() and StoreByValueTest#getAndPut_Existing_NonSameKey_MutateKey tests in the TCK fail

gregrluck commented 13 years ago

Ryan

Can you create an issue for this in the project. I will get the Terracotta Engineers to add the missing functionality to Ehcache core.

On 09/11/2011, at 12:42 AM, Ryan Gardner wrote:

Currently the StoreByValueTest#get_existing_MutateKey() and StoreByValueTest#getAndPut_Existing_NonSameKey_MutateKey tests in the TCK fail

Reply to this email directly or view it on GitHub: https://github.com/jsr107/ehcache-jcache/issues/3

Regards

Greg Luck

web: http://gregluck.com skype: gregrluck yahoo: gregrluck mobile: +61 408 061 622

ryangardner commented 13 years ago

I opened an issue here:

https://jira.terracotta.org/jira/browse/EHC-891

and migrated the TCK test that is failing into a test case that only uses Ehcache so hopefully the engineer looking at it will be able to look into it quickly.

Ryan On Nov 8, 2011 7:43 PM, "Greg Luck" < reply@reply.github.com> wrote:

Ryan

Can you create an issue for this in the project. I will get the Terracotta Engineers to add the missing functionality to Ehcache core.

On 09/11/2011, at 12:42 AM, Ryan Gardner wrote:

Currently the StoreByValueTest#get_existing_MutateKey() and StoreByValueTest#getAndPut_Existing_NonSameKey_MutateKey tests in the TCK fail

Reply to this email directly or view it on GitHub: https://github.com/jsr107/ehcache-jcache/issues/3

Regards

Greg Luck

web: http://gregluck.com skype: gregrluck yahoo: gregrluck mobile: +61 408 061 622

Reply to this email directly or view it on GitHub: https://github.com/jsr107/ehcache-jcache/issues/3#issuecomment-2676017

ryangardner commented 12 years ago

In the JCache adapter layer, I now have it clone the key if the cache is set up to storeByValue before it creates the Element that gets stored in the ehcache. (I tried using a custom copy strategy, but the key is not read out of the Element returned from the CopyOnWrite strategy - so I had to clone it further up the stream)