search

ehcache / ehcache-jcache

The Ehcache 2.x implementation of JSR107 (JCACHE)
Other
91 stars 48 forks source link

fixes NPE in JCacheConfiguration #45

Closed zdanek closed 9 years ago

zdanek commented 9 years ago

fixes NPE if JCacheConfiguration is instatiated with other JCacheConfiguration

        //given
        CacheConfiguration ehCacheConfig = new CacheConfiguration("testCache", 1000);
        JCacheConfiguration originJCacheConfig = new JCacheConfiguration(ehCacheConfig);

        //when
        new JCacheConfiguration(originJCacheConfig);
alexsnaps commented 9 years ago

Hey @zdanek This seems like a definitive fix. Thanks for that! Can you please send us the contributor agreement back (see https://github.com/ehcache/ehcache3/wiki#contributor-agreement ) So I can accept all this?

zdanek commented 9 years ago

done

zdanek commented 9 years ago

Hey @alexsnaps, what now with this PR?

alexsnaps commented 9 years ago

Merged. Thanks!

alexsnaps commented 9 years ago

Ugh! Looks like this broke something: https://ehcache.ci.cloudbees.com/job/ehcache-jcache/21/org.ehcache$jcache/testReport/org.ehcache.jcache/JCacheCachingProviderTest/testLoadsXMLFile/

I'll look into that...