ehcache / ehcache3

Ehcache 3.x line
http://www.ehcache.org
Apache License 2.0
2.02k stars 580 forks source link

org/ehcache/core/spi/store/Store.java using javax.* reference on jakarta branch #3172

Closed ghost closed 1 year ago

ghost commented 1 year ago

Hi!

The class is using javax.annotation.NonNull, instead of its jakarta.* counterpart. Can you guys fix it?

Thanks!

chrisdennis commented 1 year ago

There is no runtime dependency on the module, and given how few usages there are the only fix you're likely to see for this would be dropping the @Nonnull annotations entirely. Would that be acceptable here?

ghost commented 1 year ago

Yes. I agree.