ehcache / ehcache3

Ehcache 3.x line
http://www.ehcache.org
Apache License 2.0
2k stars 578 forks source link

Code rollback issues #3221

Open toplifangkai opened 4 months ago

toplifangkai commented 4 months ago

BatchingLocalHeapWriteBehindQueue: public void run() { List<BatchOperation<K, V>> batches = createMonomorphicBatches(operations()); // execute the batch operations for (BatchOperation<K, V> batch : batches) { try { try { batch.performOperation(cacheLoaderWriter); } finally { try { for (K key : batch.getKeys()) { latest.remove(key); } } finally { LOGGER.debug("Cancelling batch expiry task"); expireTask.cancel(false); } } } catch (Exception ex) { for (K key : batch.getKeys()) { keyCleanUpMethod.accept(key); } LOGGER.warn("Exception while bulk processing in write behind queue", ex); } } }

new: in master and since tag v3.10.9-internal9 for (K key : batch.getKeys()) { latest.remove(key); } before: for (SingleOperation<K, V> op : operations()) { latest.remove(op.getKey(), op); }

I would like to know why you changed it back. Are there any special considerations? Thank you!