palmanojkumar
commented
9 years ago Different ways to fix this problem are:
- The obvious fix is at EhcacheManager#createNewEhcache() where if WriteBehindConfiguration is found and CacheLoaderWriter is null then we can throw appropriate exception message to user instead of NullPointerException.
- Other approach is validate all provided service configurations at CacheConfigurationBuilder level where each ServiceConfiguration should validate its own configuration and ensure availability or correctness of required ServiceConfiguration.
For Example:
- ResourcePoolsBuilder should validate whether configuration for heap, offheap and disk is appropriate.
- WriteBehindConfiguration should ensure that CacheLoaderWriterConfiguration is available.
Proposed change:
public interface ServiceConfiguration<T extends Service> {
/**
* Indicates which service this configuration works with.
*
* @return the service type
*/
Class<T> getServiceType();
void validate(List<ServiceConfiguration> serviceConfigurations) throws ValidationException;
}
Take the following code:
Here the Default CacheLoaderWriter Configuration is missing, which is a problem since we need to define a CacheLoaderWriter when enabling writebehind.
An exception is correctly thrown during the cachemanager creation, however, the exception is a NPE, while it could be a more explicit one, to tell that the config is missing the CacheLoaderWriter definition.