Closed kennymacleod closed 10 years ago
alexsnaps
commented
10 years ago Hey Kenny, Thanks for the contribution, yet prior to merging this in, I'd need you to sign and send this form back to us: http://www.terracotta.org/confluence/download/attachments/27918462/Terracotta+Individual+Contributor+Agreement+v3.pdf?version=1&modificationDate=1393442245216
kennymacleod
commented
10 years ago Hi Alex,
I've fired off the agreement to our legal bods. Hopefully they'll approve it shortly and I'll have the form sent back to you,
Kenny
On 21 March 2014 03:38, Alex Snaps notifications@github.com wrote:
Hey Kenny, Thanks for the contribution, yet prior to merging this in, I'd need you to sign and send this form back to us: http://www.terracotta.org/confluence/download/attachments/27918462/Terracotta+Individual+Contributor+Agreement+v3.pdf?version=1&modificationDate=1393442245216
Reply to this email directly or view it on GitHubhttps://github.com/Terracotta-OSS/ehcache-sizeofengine/pull/27#issuecomment-38190143 .
kennymacleod
commented
10 years ago OK, I've sent the signed agreement to contributors@terracotta.org
On 21 March 2014 09:23, Kenny MacLeod kmacleod@atlassian.com wrote:
Hi Alex,
I've fired off the agreement to our legal bods. Hopefully they'll approve it shortly and I'll have the form sent back to you,
Kenny
On 21 March 2014 03:38, Alex Snaps notifications@github.com wrote:
Hey Kenny, Thanks for the contribution, yet prior to merging this in, I'd need you to sign and send this form back to us: http://www.terracotta.org/confluence/download/attachments/27918462/Terracotta+Individual+Contributor+Agreement+v3.pdf?version=1&modificationDate=1393442245216
Reply to this email directly or view it on GitHubhttps://github.com/Terracotta-OSS/ehcache-sizeofengine/pull/27#issuecomment-38190143 .
kennymacleod
commented
10 years ago The mail to that address bounced with an error from the softwareag.com mail server. Is there somewhere else I can send it?
On 3 April 2014 16:59, Kenny MacLeod kmacleod@atlassian.com wrote:
OK, I've sent the signed agreement to contributors@terracotta.org
On 21 March 2014 09:23, Kenny MacLeod kmacleod@atlassian.com wrote:
Hi Alex,
I've fired off the agreement to our legal bods. Hopefully they'll approve it shortly and I'll have the form sent back to you,
Kenny
On 21 March 2014 03:38, Alex Snaps notifications@github.com wrote:
Hey Kenny, Thanks for the contribution, yet prior to merging this in, I'd need you to sign and send this form back to us: http://www.terracotta.org/confluence/download/attachments/27918462/Terracotta+Individual+Contributor+Agreement+v3.pdf?version=1&modificationDate=1393442245216
Reply to this email directly or view it on GitHubhttps://github.com/Terracotta-OSS/ehcache-sizeofengine/pull/27#issuecomment-38190143 .
alexsnaps
commented
10 years ago Awesome! Just tried from my gmail address and yes, someone restricted the list. Can you send it to me at alex.snaps at terracottatech dot com ? I'll make sure it gets to the right people and merge this pull request in... Thanks for noticing AND sharing the issue with us though!
This makes small changes to how EhcacheSizeOfEngine logs MaxDepthExceededExceptions.
Firstly, it reduces the logging of the keys and values from WARN to DEBUG. This makes sense given that the warning relates to the fact that the exception has occurred, but logging of the keys and values can be extremely verbose, and is useful only for debugging the problem. When both are logged at WARN, then your only option is to get all of it, or none of it.
The second aspect of the change is to move the logging into a protected method, so that subclasses can more easily override this behaviour if they choose.