ehealthsuisse / ch-epr-fhir

Repository for the swiss implementation guide for the FHIR based profiles
3 stars 5 forks source link

Comments on PIXm/PDQm #73

Closed qligier closed 8 months ago

qligier commented 1 year ago

~No Patient profile and no mapping with PIXv3/PDQv3?~ fixed by #115

http://fhir.ch/ig/ch-epr-mhealth/iti-104.html

~All links to the PIXm profile lead to the latest version, while the label specifies v3.0.0.~ won't fix

~Typo: SHALL be conform to the PIXm → be conformed, or conform~ tracked in #106

~The EPR-SPID as an identifier MAY be added: In Annex 5 §1.7.1.1, the EPR-SPID SHALL be conveyed.~ tracked in #111

~Resolve Duplicate Patient: is it really allowed to clients? It seems an operation for administrators only, because that would change access to the discarded patient.~ allowed, no change needed

~Add Patient: is it really allowed to clients? It was supported in PIXv3, but seems weird nonetheless.~ allowed, no change needed

http://fhir.ch/ig/ch-epr-mhealth/iti-78.html

~The link URL and label to the IHE PDQm profile are wrong.~ fixed in 7496ff7

~The link to FHIR leads to R5.~ fixed in 9ba6757

~The message semantics is the same as defined in 2:3.78.4.1.2: In Annex 5 §1.9.1.1: The PatientTelecom Query Parameter MUST NOT be used. Why is it allowed here?~ tracked in #117

~If there are more than 5 matches, the result should return zero matches.: An OperationOutcome should be required in that case, with the details provided in the XDS counterpart.~ tracked in #80

http://fhir.ch/ig/ch-epr-mhealth/iti-83.html

~The link to FHIR leads to R5.~ fixed in 9ba6757

~targetSystem: SHALL be Restricted to the Assigning authority of the community and/or the EPR-SPID.: In Annex 5 §1.8.1.1: The DataSource Parameter SHALL be specified to the assigning authorities of the EPR-SPID and the MPI-PID in the affinity domain. The 'or' is not allowed in PIXv3.~ tracked in #112

http://fhir.ch/ig/ch-epr-mhealth/StructureDefinition-ch-pixm-patient.html

~Patient.contact.relationship is allowed (and required). In Annex 5 §1.7.1.1, PersonalRelationship.code must not be used.~ tracked in #119

http://fhir.ch/ig/ch-epr-mhealth/StructureDefinition-ch-pixm-provider-organization.html

~Typo: The value shall be expressed as and ISO OID → as an ISO OID~ tracked in #106

oliveregger commented 8 months ago

104:


Typo: SHALL be conform to the PIXm → be conformed, or conform SHALL conform to PIXm

https://fhir.ch/ig/ch-epr-mhealth/iti-104.html#:~:text=If%20the%20patient%20is%20already%20registered%20in%20a%20community%2C%20the%20MPI%2DPID%20SHALL%20be%20provided%20as%20an%20identifier.%20The%20EPR%2DSPID%20as%20an%20identifier%20MAY%20be%20added.

Change text to: SHALL convey the patient’s local ID and the EPR-SPID.

https://fhir.ch/ig/ch-epr-mhealth/StructureDefinition-ch-pixm-patient.html EPR-SPID min cardinality should be 1 and Identifier cardinalty should be 2 (except we would map additional identifieres to otherIdenttifiers in PIXv3)

Resolve Duplicate Patient/Add Patient: both are allowed sending the messages what happened in the local system.

oliveregger commented 8 months ago

78:

The link URL and label to the IHE PDQm profile are wrong. fix PQD in link: https://profiles.ihe.net/ITI/PQDm/index.html link to the correct version

The link to FHIR leads to R5. adjust link to r4 for every occurence

The message semantics is the same as defined in 2:3.78.4.1.2: In Annex 5 §1.9.1.1: The PatientTelecom Query Parameter MUST NOT be used. Why is it allowed here?

need to add the sentence too for ITI-78 and split request reponse message semantics (or within the text)

If there are more than 5 matches, the result should return zero matches.: covered in https://github.com/ehealthsuisse/ch-epr-mhealth/issues/80

oliveregger commented 8 months ago

83:

targetSystem: SHALL be Restricted to the Assigning authority of the community and/or the EPR-SPID.: In Annex 5 §1.8.1.1: The DataSource Parameter SHALL be specified to the assigning authorities of the EPR-SPID and the MPI-PID in the affinity domain. The 'or' is not allowed in PIXv3. needs to change to

targetSystem: SHALL be Restricted to the Assigning authority of the community and the EPR-SPID

oliveregger commented 8 months ago

Patient.contact.relationship is allowed (and required). In Annex 5 §1.7.1.1, PersonalRelationship.code must not be used.

@msmock PersonalRelationship.code must not be used in the feed, but we are able to query it with FTH and MTH (1.9 Requirements on PDQV3 for Patient Demographics Query). does this make sense?

oliveregger commented 8 months ago

Typo: The value shall be expressed as and ISO OID → as an ISO OID fix typo

oliveregger commented 8 months ago

TODO Oliver: Create a Change Proposal that code [1..1] (M) Role (CE) {CWE:PersonalRelationshipRoleType} is changed to No further refinement (or harmonized with Query where MTH and FTH is used).

qligier commented 8 months ago

The issue has been split.