search

ehealthsuisse / ch-epr-ppqm

PPQ für mobile apps
1 stars 2 forks source link

Missing referenced Policy Sets #22

Closed qligier closed 1 year ago

qligier commented 1 year ago

In PPQm Referenced Policy Set, two Policy Sets are missing: urn:e-health-suisse:2015:policies:policy-bootstrap and urn:e-health-suisse:2015:policies:doc-admin. Are they forbidden here, or were they forgotten ? If forbidden, a short explanation would be useful.

unixoid commented 1 year ago

Nothing is forgotten :-) These policy sets are never referenced from templates, see Section 2 in https://github.com/ehealthsuisse/ch-epr-adr-ppq/blob/main/docs/Policies.md.

qligier commented 1 year ago

Is it only in the schema, where policy sets 1-9 are shown? In 2.2, they are described like the 9 others.

unixoid commented 1 year ago

The picture https://github.com/ehealthsuisse/ch-epr-adr-ppq/raw/main/docs/policies.png shows, which base policy sets (on the magenta background) may be referenced from policy set templates (on the yellow background). As you see, doc-admin and policy-bootstrap are not among them. As the CH:PPQm profile covers only policy sets created from the templates, it completely ignores the existence of doc-admin and policy-bootstrap.

If, at some point, the coding system PpqmReferencedPolicySet will lose the prefix Ppqm in its name and be moved from the CH:PPQm IG to the CH:EPR-Term IG, then yes, it will have to include all references. But not yet.

qligier commented 1 year ago

If, at some point, the coding system PpqmReferencedPolicySet will lose the prefix Ppqm in its name and be moved from the CH:PPQm IG to the CH:EPR-Term IG, then yes, it will have to include all references. But not yet.

In that case, you would still need a PpqmReferencedPolicySet value set. It makes sense not to have the two special elements here, I only wish a note explaining the value set does not contain the admin policy sets because they are not actionable, and thus forbidden in these exchanges.

unixoid commented 1 year ago

Ok, I will add such comment.

unixoid commented 1 year ago

And, BTW, I will not still need this value set. Actually, neither do I need it now. This is because of the ch-epr-ppqm-template-structure validation constraint in PpqmConsent.

qligier commented 1 year ago

It is also used as binding on Consent.policyRule.coding.

(Typo in ch-epr-ppqm-template-structure: correspong -> correspond)

unixoid commented 1 year ago

This is what I mean, this binding is not necessary as its effect is duplicated in the validation constraint. But I will keep it nevertheless.

(Thanks.)

qligier commented 1 year ago

Okay, I understand now, thanks!

dkotlaris commented 1 year ago

26.10.2023: Accepted.