ehennenfent / binja_explain_instruction

Adds a window to Binary Ninja that explains in simple-ish English what an instruction does
Apache License 2.0
51 stars 4 forks source link

Failed to load plugin due to PySide6 #5

Open mubix opened 2 years ago

mubix commented 2 years ago
  File "C:\Users\user\AppData\Roaming\Binary Ninja\plugins\binja_explain_instruction\__init__.py", line 3, in <module>
    from PySide6.QtGui import QImage
ModuleNotFoundError: No module named 'PySide6'
Python plugin 'binja_explain_instruction' could not be loaded
galenbwill commented 2 years ago

This does not happen to me. @mubix are you sure you have PySide6 installed in the python that Binary Ninja is using?

mubix commented 2 years ago

@galenbwill ya sorry I didn't add more of an explanation to the original issue text. I did install PySide6 and was able to get it to work. I was simply stating that no where in the README.md or plugin.json does it state any dependencies - https://github.com/ehennenfent/binja_explain_instruction/blob/master/plugin.json#L13

galenbwill commented 2 years ago

PySide6 is a standard dependency of any and all Binary Ninja python-based UI plugins, so I wouldn't expect it to be in the plugin.json for any plugin.

Did you install via the Plugin Manager in Binary NInja?