ehennestad / openMINDS-MATLAB-UI

A matlab interface for openMINDS
MIT License
2 stars 1 forks source link

Fix: Update table viewer to work with openminds.Collection #8

Open ehennestad opened 2 months ago

ehennestad commented 2 months ago

The current implementation uses a Metadata Collection class that predates the openminds.Collection from openMINDS_MATLAB. Ideally the openminds.Collection should be used in this toolbox.

Differences from the openminds.Collection

Properties that are referred to by TableViewer / MetadataEditor app

Methods that are used by TableViewer / MetadataEditor app

Events

Discussion:

Question: How to consolidate the openminds.Collection with the requirements from the GUI?

Alternative 1: Subclass openminds.Collection

Alternative 2: Expand openminds.Collection to have events and methods for providing table/ graph types

Alternative 3: Strategy pattern: i.e openminds.Collection is a property in om.ui.Collection

ehennestad commented 2 months ago

Alternative A seems most straight forward. Additional properties, methods and events should be additional to the "core" collection and only relevant in the GUI context. Saving a UICollection as an openminds.Collection and creating a UICollection from an openminds.Collection should be supported.