search

eherr / anim_utils

Data structures and utilities for skeleton animations.
Other
39 stars 14 forks source link

Root translation lost #3

Open gemlongman opened 4 years ago

gemlongman commented 4 years ago

https://github.com/eherr/anim_utils/blob/9a4c2842d9157f631d6207bf92da9f89a915ca4f/retargeting/analytical.py#L319

In some situations，hips joint has a fixed root joint as its parent. After retargeting, hips joint will loss translation and be fixed. Meanwhile, there are some children joints also need Xposition,Yposition and Zposition channels in retargeting and bvh-file writer.

eherr commented 4 years ago

Ok yes currently the function assumes that you only have translation in the root joint. This is a limitation of the code. If it is useful, I will try to make it more general. However this is more work and might take a while, because the assumption is used also in the Skeleton class.

gemlongman commented 4 years ago

Ok yes currently the function assumes that you only have translation in the root joint. This is a limitation of the code. If it is useful, I will try to make it more general. However this is more work and might take a while, because the assumption is used also in the Skeleton class.

It is lots of work to make more general, although it is not very difficult. Maybe just leave it alone.