search

ehgoodenough / papercut

A game about timeflux ninja combat.
5 stars 4 forks source link

Can has PlayFab? #75

Closed skylarjhdownes closed 8 years ago

skylarjhdownes commented 8 years ago

Stuff from yesterday.

skylarjhdownes commented 8 years ago

Is there a way to attach the Issue/bug to this? I suppose I can just link it: https://github.com/ehgoodenough/papercut/issues/74

ehgoodenough commented 8 years ago

Yup! If you just type the number, just like you did, it'll link it to the issue. That's why PRs and Issues share the same numbering system.

ehgoodenough commented 8 years ago

I'm currently debating whether to merge this; now that the hackathon is over, I just don't care about PlayFab anymore. Hrmmm..

skylarjhdownes commented 8 years ago

I suppose I ought to pull the bugfixes off into their own branch so we can merge them separately. Can I do that locally and then just push, or is it more in depth than that? I am still a branching newb.

ehgoodenough commented 8 years ago

Yeah, you could git checkout -b my-new-branch, but I think it'd just be easier to merge this, and then just ignore the PlayFab stuff unless we need it, you know?