search

ehharvey / lms-2024

3 stars 2 forks source link

Change Credits module to Credit (singular) #212

Closed ehharvey closed 1 week ago

ehharvey commented 1 month ago

Our modules should be singular

chauhan2b commented 3 weeks ago

Can you elaborate the issue?

private String EhharveyCredits() {...} BECOMES private String EhharveyCredit() {...} ?

ehharvey commented 1 week ago

Hi! Apologies, did not see this.

All of our modules (e.g., classes) should be singular. So the class itself should be Credit, not Credits. This should also affect the command use (instead of lms credits list it should be lms credit list).

As for members inside the Credits module, I'm less concerned, but could be worth changing too.

I would like focus on the module / command though.