search

ehmatthes / django-simple-deploy

A reusable Django app that configures your project for deployment
BSD 3-Clause "New" or "Revised" License
307 stars 26 forks source link

docs: additional git instructions on contributing #224

Closed dversoza closed 1 year ago

dversoza commented 1 year ago

This PR adds a new section to the contributing/development_environment.md file that provides instructions on how to clone the repository, set up an upstream remote, and configure git to pull from upstream and always push to origin.

This makes it more consistent to fetch and pull from the upstream remote (the official repository's main branch), while keeping the regular flow of pushing to the user's fork.

darjeeling commented 1 year ago

looks good to me. with this new folks can do something

ehmatthes commented 1 year ago

Thanks for this! I have not had time to pull these larger PRs locally to look at them yet, but I should be able to get to them tonight or tomorrow morning.

ehmatthes commented 1 year ago

This looks great. When I originally wrote these steps, I was not thinking about needing to pull from upstream, etc.

Before I merge this, can you tell me what git@github-pessoal is? Is that the same for everyone, or should that be replaced by a placeholder?

dversoza commented 1 year ago

Hi @ehmatthes, I'm sorry about that! I use a local setting in my dev environment that was outputted when I ran the command. It shouldn't be there for other engineers.

I fixed it!