The logic around checking for a clean git status, but allowing addition of simple_deploy to INSTALLED_APPS and creation of simple_deploy_logs/ is flawed. Having a clean status passes, but jumping straight to git diff is problematic. Focus on git status --porcelain. Most checks should come from that.
[ ] Run simple_deploy against a project which has been initialized, but doesn't have its first commit. (That just passed the status check on Windows!)
[ ] Can we remove the need to call git diff entirely?
The logic around checking for a clean git status, but allowing addition of simple_deploy to INSTALLED_APPS and creation of simple_deploy_logs/ is flawed. Having a clean status passes, but jumping straight to
git diff
is problematic. Focus ongit status --porcelain
. Most checks should come from that.git diff
entirely?