Refactor fly_io/deploy.py

[ehmatthes]

The work to stabilize Fly deployments introduced more complex behavior in some methods, and introduced new methods. I can make a release without refactoring, because that work had external changes. This should be only internal changes, so I can do this work as a separate set of tasks.

• [x] Refactor _get_deployed_project_name().
• [x] Refactor _create_flyio_app() using --json.
• [x] Include path to temp project in final output of integration test.
• [x] Refactor _create_db().
• [x] Look at _check_db_attached().
• [x] Look for any remaining fly calls that could use --json.
• [ ] Consider adding a flag to fly integration test, --pre-existing-app. Call platform_utils.create_project() twice; add both of these to cache; destroy both of these at end of test run. See comment in #263.
• [x] Review entire file.
  • [x] public methods
  • [x] helper methods for deploy()
    • [x] _set_on_flyio()
    • [x] _set_debug()
    • [x] _add_dockerfile()
    • [x] _add_dockerignore()
    • [x] _add_flytoml_file()
    • [x] _modify_settings()
    • [x] _add_requirements()
    • [x] _conclude_automate_all()
    • [x] _show_success_message()
  • [x] other helper methods
• [x] Test.
  • [x] unit tests
  • [x] one integration test
• [x] Run black; any reason not to keep changes?
  • I don't like squashing comprehensions with conditionals, and I'm not alone. But it's still worth the consistency.
• [x] Merge PR. No release needed, as no external changes.

[ehmatthes]

Documentation

• [ ] Update the reference to fly open on the quick start, to avoid the warning about deprecating fly open.

[ehmatthes]

Remaining from #101

• [x] Make a more specific ALLOWED_HOSTS entry.

[ehmatthes]

Working notes

• [x] Use a more consistent style for docstrings. See PEP 257. See also _get_deployed_project_name() as an example.
• [ ] Run black after refactoring this entire file.

[ehmatthes]

Refactoring _get_deployed_project_name()

• [x] Run through entire method, cleaning up comments and logic.
• [x] Reorganize deploy.py: deploy(), validate_platform(), prep_automate_all(), deploy helpers, validate helpers, any other methods.
• [x] Integration tests pass. (10s pause inserted before functionality testing, because lots of false failures there recently.)
• [x] Break up into smaller methods. It's over 100 lines.
• [x] Refactor _select_project_name().
  • [x] Use alias sd_utils for import statement.
  • [x] Run black against sd_utils.
• [x] Run unit tests.
• [x] Run integration tests.

[ehmatthes]

Refactor _create_flyio_app() using --json

• [x] Use --json in call to fly apps create.
• [x] Run integration test.
• [x] Use results of _get_region() to create app in appropriate region? (No need, apps don't have regions.)
  • [x] Where is _get_region() currently being used? My guess is it's being used to create db? (Correct)
  • [x] Maybe if self.app_name is already set, use the region associated with that app when creating db?
  • [x] See forum question.
• [ ] Run integration test.

[ehmatthes]

Refactor _create_db()

• [x] Reduce nesting.
• [x] Refactor _check_db_exists().
• [x] Use --json in _check_db_attached(). (Not possible. Clean up string parsing instead.)
• [x] Run a manual deployment after creating an app and db, and see that this still works.
• [x] Refactor _attach_db().
• [x] Refactor _confirm_create_db().
• [x] Refactor _attach_db().
• [x] Resolve: I think self.app_name and self.deployed_project_name are used interchangeably?
• [x] Remove needlessly long docstrings from helper methods.

[ehmatthes]

Refactor validate_platform()

Current logic around creating an app with --automate-all was inconsistent. _get_deployed_project_name() was not running for automated runs. _get_deployed_project_name() can do the work of creating an app during automated runs.

• [x] Move call to _create_flyio_app() from validate_platform() to _get_deployed_project_name().
• [x] Testing:
  • [x] Run automate-all integration test.
  • [x] create an app, then run automate-all integration test
  • [x] create an app, then run with --automate-all, reject that app.
  • [x] create two apps, then run with --automate-all, reject those apps.

[ehmatthes]

Refactor _add_dockerfile()

• [x] Is there a difference between sd.git_path and sd.project_root? (Maybe, ie if it's a nested project.)
• [x] Use path.exists(), instead of os.listdir.

[ehmatthes]

Closed by #282.