Refactor with focus on plugin consistency

[ehmatthes]

We need a bit more refactoring before moving plugins to external packages. Refactor, with a focus on supporting this move.

• [x] Run black against entire project.
  • [x] Make sure all local tests pass.
  • [x] Make sure one e2e test passes.
• [ ] Support consistent approaches across all platforms, such as confirming before overwriting.
  • [ ] Consider an "all" response, if would like permission to overwrite all files found.
  • [ ] Make sure approach to selecting from multiple resources such as orgs and project names is consistent.
• [ ] Pull common tasks into utilities.
  • [ ] Make a clear separation between internal sd utils, which plugins should never use (or can't use), and public utils, which they're expected to use.
  • [ ] Add some unit tests as applicable to utilities.
• [ ] Ensure a consistent directory structure across plugins.
• [ ] Ensure clean import structures.

[ehmatthes]

Run black against entire project

• [x] commands/ non-plugins files
• [x] Fly
• [x] Platform.sh
• [x] Heroku
• [x] Run all tests.
  • [x] test_git_status_checks() is failing. Run just this test file, and troubleshoot.
  • [x] Run just this test, and troubleshoot test_add_sd_installed_apps(); seems to be generating an unclean git status.
• [x] All
• [x] Note this in changelog.
• [x] Update contributing docs/ coding guide.
• [ ] Merge
• [x] Note in parking lot to add this to CI.

[ehmatthes]

Make plugins consistent

Look for consistent approaches to common tasks.

• [ ] If an existing file is found, ask permission to overwrite it.
  • [x] Move current commit off main?
  • [x] Generalize the "file {__} found", and overwrite messages.
  • [x] Move those messages to simple_deploy.
  • [x] Write unit tests for cross-platform deployment messages, focusing on dynamic messages.
  • [x] Remove those messages from platform-specific files.
    • [x] Fly docker file (replace with cross-platform messages)
  • [x] Write a single test for this using Fly.
  • [ ] Clean up language around replacing files, ie looking for file followed by found, can replace, no docker file found...
  • [ ] Write an sd method for getting permission to replace a file.
  • [ ] Fly
  • [ ] Platform.sh
  • [ ] Heroku

[ehmatthes]

Troubleshoot test: test_add_sd_installed_apps()

• simple_deploy was being added with single quotes.
• settings file ends up with no trailing newline; sample project starts with a trailing newline.
• Fix: splitting settings file into lines and then putting it back together was losing the trailing newline.