Parking lot

[ehmatthes]

This is a holding place for issues that arise in working toward 1.0, but aren't worth a separate issue that will likely become stale for a while. If you want to work on one of these tasks, feel free to open a new issue dedicated to that task. I want to avoid having a large number of small issues open, making the project look less maintained than it is.

[ehmatthes]

• [ ] When running Platform.sh e2e tests, if the CLI is not authenticated the test hangs on the first run. A subsequent run catches the not authenticated error message. Not obvious to troubleshoot quickly, because it's only some runs that hang. Problem likely in platform_sh/tests/e2e_tests/utils.py:

  def check_logged_in():
  """Check that user is currently logged in to Platform.sh through CLI."""
  print("\nVerifying logged in to Platform.sh CLI...")
  auth_info_output = make_sp_call("platform auth:info --quiet", capture_output=True)
  if "LoginRequiredException" in auth_info_output.stderr.decode():
      msg = "\n----- Error: Not logged in through CLI -----"
      msg += "\nPlease log in to the Platform.sh CLI and then run the e2e test."
      msg += "\n  You can log in with the command: platform login"
      msg += "\n-----\n"
      print(msg)
  
      exit_msg = "Please run `platform login` and then run e2e tests."
      pytest.exit(exit_msg)

• [ ] Ensure each platform's CLI is updated before running e2e tests? Many failures seem to come from the CLI being updated automatically during the test run, which interferes with the automated deployment/testing process.

[ehmatthes]

Tasks related to supporting plugins

• [ ] Separate private utils from public utils. Public utils are utils that are meant to be used by plugins. See #340.
  • [ ] Consider utils/sd_utils.py and utils/plugin_utils.py.
• [ ] Separate functions from methods? Or can functions simply accept sd object?
  • [ ] If functions accept sd object, consider mocking sd object for testing purposes.
• [ ] utils.add_file() should validate that either contents is provided, or template and context are provided. Not all three.
  • [ ] Or, contents should be rendered by calling function, and this function only takes contents?