dedupe query function definition body - extract repeated logic to generic fn

[uladkasach]

// client method for query 'find_geocode_by_id'
export const sqlQueryFindGeocodeById = async ({
  dbExecute,
  logDebug,
  input,
}: {
  dbExecute: DatabaseExecuteCommand;
  logDebug: LogMethod;
  input: SqlQueryFindGeocodeByIdInput;
}): Promise<SqlQueryFindGeocodeByIdOutput[]> => {
  // 1. define the query with yesql
  const { sql: preparedSql, values: preparedValues } = prepare(sqlQueryFindGeocodeByIdSql)(input);

  // 2. log that we're running the request
  logDebug('sqlQueryFindGeocodeById.input', { input });

  // 3. execute the query
  const [output] = await dbExecute({ sql: preparedSql, values: preparedValues });

  // 4. log that we've executed the request
  logDebug('sqlQueryFindGeocodeById.output', { output });

  // 5. return the output
  return output;
};

to

import { DatabaseExecuteCommand, LogMethod } from 'sql-code-generator';

// client method for query 'find_geocode_by_id'
export const sqlQueryFindGeocodeById = async ({
  dbExecute,
  logDebug,
  input,
}: {
  dbExecute: DatabaseExecuteCommand;
  logDebug: LogMethod;
  input: SqlQueryFindGeocodeByIdInput;
}): Promise<SqlQueryFindGeocodeByIdOutput[]> => mysqlBestPracticesExecute({ name: 'sqlQueryFindGeocodeById', sql: sqlQueryFindGeocodeByIdSql, input })

where

const mysqlBestPracticesExecute = ({ name: string, sql: string, input: any }) => {
  // 1. define the query with yesql
  const { sql: preparedSql, values: preparedValues } = prepare(sqlQueryFindGeocodeByIdSql)(input);

  // 2. log that we're running the request
  logDebug(`${name}.input`, { input });

  // 3. execute the query
  const [output] = await dbExecute({ sql: preparedSql, values: preparedValues });

  // 4. log that we've executed the request
  logDebug(`${name}.output`, { output });

  // 5. return the output
  return output;
}; 

[uladkasach]

note: generate the mysqlBestPracticesExecute - to make it easy to edit for users, or import it?

[uladkasach]

not importing is more in line with the spirit of generator.

[uladkasach]

const executeQueryWithBestPracticesForMysql = async ({
  dbExecute,
  logDebug,
  name,
  sql,
  input,
}: {
  dbExecute: DatabaseExecuteCommand;
  logDebug: LogMethod;
  name: string;
  sql: string;
  input: any;
}) => {
  // 1. define the query with yesql
  const { sql: preparedSql, values: preparedValues } = prepare(sql)(input);

  // 2. log that we're running the request
  logDebug(`${name}.input`, { input });

  // 3. execute the query
  const [output] = await dbExecute({ sql: preparedSql, values: preparedValues });

  // 4. log that we've executed the request
  logDebug(`${name}.output`, { output });

  // 5. return the output
  return output;
};

[uladkasach]

but importing might help prevent the changing generated code problem.

plus, it is really easy to swap out for your own - so it wouldn't be a blocker...

[uladkasach]

significant con of "importing" - it would then have to be a "dependency" instead of a "dev dependency". so, no imports