search

ehn-dcc-development / eu-dcc-schema

Schema for the ehn DCC payload
Apache License 2.0
165 stars 59 forks source link

Fixes missing descriptions of "tg" properties in test and recovery groups #130

Closed Jakub-KK closed 2 years ago

Jakub-KK commented 2 years ago

Fixes #129

dslmeinte commented 2 years ago

Hi @Jakub-KK , Thanks for the PR! This change can't go into the 1.3.0 release, however. Instead, it should go into a new release branch (1.3.1, probably). I'll have to confer with my eHN colleagues what we're going to do.

kruzikh commented 2 years ago

Hi, agree for sure. I presume that once release 1.3.1 will be pushed to main, this change will be visible in all release after 1.3.1 wright?

dslmeinte commented 2 years ago

Hi, agree for sure. I presume that once release 1.3.1 will be pushed to main, this change will be visible in all release after 1.3.1 wright?

That's correct.

dslmeinte commented 2 years ago

Hi @Jakub-KK , I changed the PR target to the newly-minted release/1.3.1 branch. Could you rebase your PR on that branch?

Jakub-KK commented 2 years ago

Hi @dslmeinte, I rebased my commit.

dslmeinte commented 2 years ago

Thanks @Jakub-KK for your contribution! 🙏