search

ehn-dcc-development / eu-dcc-schema

Schema for the ehn DCC payload
Apache License 2.0
164 stars 59 forks source link

`test-manf` undefined? #28

Closed vitorpamplona closed 3 years ago

vitorpamplona commented 3 years ago

I noticed there are pre-defined ValueSets for the test-manf field, but I don't seem to find a descriptor for those options anywhere. Am I missing something?

dirkx commented 3 years ago

So you have the value lists in the DCG*schema.json - and you have the lookup tables here: https://github.com/ehn-digital-green-development/ehn-dgc-schema/blob/main/Lookup-tables/DGC-valueset-lookup.json -- that is not what you are looking for ?

vitorpamplona commented 3 years ago

I am looking for descriptors for the numbers below. They don't seem to be defined on the valueset lookup. 

 "test-manf": {
      "description": "EU eHealthNetwork: Value Sets for Digital Green Certificates. version 1.0, 2021-04-16, section 2.8",
      "type": "string",
      "enum": [
        "1232",
        "1304",
        "1065",
        "1331",
        "1484",
        "1242",
        "1223",
        "1173",
        "1244",
        "1360",
        "1363",
        "1767",
        "1333",
        "1268",
        "1180",
        "1481",
        "1162",
        "1271",
        "1097",
        "1489",
        "344",
        "345",
        "1218",
        "1343"
      ]
    },
dirkx commented 3 years ago

Ah - sorry my bad - I assumed that the values in Lookup-tables/DGC-RAT-lookup.jso were what you where looking for ??

{
  "1232": {
    "display": "Abbott Rapid Diagnostics, Panbio COVID-19 Ag Test",
    "lang": "en",
    "active": true,
    "system": "https://covid-19-diagnostics.jrc.ec.europa.eu/devices",
    "version": "2021-04-22 02:23:55 CET",
    "valueSetId": "covid-19-lab-test-manufacturer-and-name"
  },
  "1304": {
    "display": "AMEDA Labordiagnostik GmbH, AMP Rapid Test SARS-CoV-2 Ag",
    "lang": "en",
    "active": true,
    "system": "https://covid-19-diagnostics.jrc.ec.europa.eu/devices",
    "version": "2021-04-22 02:23:55 CET",
    "valueSetId": "covid-19-lab-test-manufacturer-and-name"
  },
vitorpamplona commented 3 years ago

Nice! Thank you!

If you want to see where we are using it: https://github.pathcheck.org/eu.dgc.html

gabywh commented 3 years ago

Issue resolved - expanded data information in the appropriate lookup table.