ehn-dcc-development / eu-dcc-schema

Schema for the ehn DCC payload
Apache License 2.0
164 stars 59 forks source link

Some value-sets include valueSetId also in value #48

Closed martin-lindstrom closed 3 years ago

martin-lindstrom commented 3 years ago

A typical value-set looks like:

{
  "valueSetId": "disease-agent-targeted",
  "valueSetDate": "2021-04-27",
  "valueSetValues": {
    "840539006": {
      "display": "COVID-19",
      "lang": "en",
      "active": true,
      "version": "http://snomed.info/sct/900000000000207008/version/20210131",
      "system": "http://snomed.info/sct"
    }
  }
}

But for some of the value-sets, the valueSetId is included also in the value. For example:

{
  "valueSetId": "vaccines-covid-19-auth-holders",
  "valueSetDate": "2021-04-27",
  "valueSetValues": {
...
    "ORG-100030215": {
      "display": "Biontech Manufacturing GmbH",
      "lang": "en",
      "active": true,
      "system": "https://spor.ema.europa.eu/v1/organisations",
      "version": "",
      "valueSetId": "vaccines-covid-19-auth-holders"
    },

This is a bug, right?