search

ehn-dcc-development / eu-dcc-schema

Schema for the ehn DCC payload
Apache License 2.0
164 stars 59 forks source link

CBOR encoding clarifications #67

Closed jschlyter closed 3 years ago

jschlyter commented 3 years ago

Update main branch with CBOR encoding clarifications, no version changes.

kruzikh commented 3 years ago

Guys I corrected the test type in json schema and added valueset for it. Please, could you check? We need to do it quickly as implementers are on a full speed!

jschlyter commented 3 years ago

@kruzikh looking good from my side, but this should bump the patchlevel version of the schema IMHO.

Next time, please make PR toward next for your specific change as the PRs next to main are for version management only.

kruzikh commented 3 years ago

Sorry, my mistake, I am still a begginer in git :-(

gabywh commented 3 years ago

Sorry, my mistake, I am still a begginer in git :-(

no problem - actually even "Next" is not standard and should be deleted. There's a whole bunch of stuff around version management (as ever) including the original "gitflow" and derivatives "gitlab flow" and "github flow" and so on... Currently we're doing none of them here :(

gabywh commented 3 years ago

but this should bump the patchlevel version of the schema IMHO. @jschlyter feel free to bump, usual semver thing

kruzikh commented 3 years ago

Gaby, coul'd you propage correct json schema into the main ASAP?

gabywh commented 3 years ago

Gaby, coul'd you propage correct json schema into the main ASAP?

Yep, just waiting on one more reviewer to give the go ahead

jschlyter commented 3 years ago

no problem - actually even "Next" is not standard and should be deleted. There's a whole bunch of stuff around version management (as ever) including the original "gitflow" and derivatives "gitlab flow" and "github flow" and so on... Currently we're doing none of them here :(

Actually, we are. We have main as our release/master branch and next as our develop branch. We've merged changes into next and once we're ready to release a set of new features as a release, we make a PR to main (and require at least 2 reviewers).

gabywh commented 3 years ago

no problem - actually even "Next" is not standard and should be deleted. There's a whole bunch of stuff around version management (as ever) including the original "gitflow" and derivatives "gitlab flow" and "github flow" and so on... Currently we're doing none of them here :(

Actually, we are. We have main as our release/master branch and next as our develop branch. We've merged changes into next and once we're ready to release a set of new features as a release, we make a PR to main (and require at least 2 reviewers).

About the only standard thing we have here is main. We're not even doing upstream first with Next and release management also missing,. but whatever, I'm not going to start arguing about sw dev process, let's leave it at that.