ehn-dcc-development / eu-dcc-schema

Schema for the ehn DCC payload
Apache License 2.0
164 stars 59 forks source link

Inconsistencies for PCR tests DGC and Rapid Test DGC #68

Closed lab-incert closed 3 years ago

lab-incert commented 3 years ago

Hello,

In LU, we face some issues regarding the definition of the JSON schema for the test DGC (PCR and Rapid Test). The following points shall be discuss.

To summarize, as it is defined right now, the JSON schema for the test DGc has the following mandatory fields:

and the optional fields:

For the two optional fields, the information is get from https://covid-19-diagnostics.jrc.ec.europa.eu/devices.

If we look at the examples within this repository (test-naa.json and test-rat.json), we observe the following:

  1. for test-naa.json
  2. for test-rat.json

Thus, we have the following remarks:

  1. In the PCR test DGC, the JSON schema contains the Commercial Name. In the Rapid Test DGC, the JSON schema contains the ID_Device. This is inconsistent, as in both types of test, the ID_Device points to the Commercial Name and the Manufacturer Name. To avoid redundancy and save some space within the QR Code, the ID_Device only should be used within the JSON schema, for both types of test.

  2. The "tr" field for Rapid Test DGC is optional, not mandatory. This shall be changed within the specification of the JSON schema (in Luxembourg, we will not have this information given by the concerned parties).

Thanks in advance for clarifying this.

gabywh commented 3 years ago

https://github.com/ehn-digital-green-development/ehn-dgc-schema/releases/tag/1.2.0 Field dr dropped

gabywh commented 3 years ago

As discussed 7 June 2021: schema plus valuesets being updated