search

ehn-dcc-development / eu-dcc-schema

Schema for the ehn DCC payload
Apache License 2.0
164 stars 59 forks source link

Update to release 1.2.0 for dropping field test/dr #80

Closed gabywh closed 3 years ago

gabywh commented 3 years ago

Test result date has been removed from the data set in the recent version of the regulation. Recovery certificate is based only on the NAA test result.

gabywh commented 3 years ago

While we are at it maybe we should update the description on dob also? It now says: "Date of Birth of the person addressed in the DGC. ISO 8601 date format restricted to range 1900-2099".

But 1950, which is an allowed string, isn't according to ISO 8601. A note telling that year only, and year+month only, is accepted should be included in the description.

Didn't include in this PR, as PR solely for upgrade to 1.2.0. I didn't understand this:

But 1950, which is an allowed string, isn't according to ISO 8601.

Could you explain?

martin-lindstrom commented 3 years ago

I thought that ISO 8601 stated that a date should be expressed as YYYY-MM-DD.

gabywh commented 3 years ago

Ah I see. YYYY alone is also valid ISO8601. As I don't have the real ISO8601 to reference, wikipedia will have to suffice: https://en.wikipedia.org/wiki/ISO_8601#Years

kruzikh commented 3 years ago

Well, restiction to range 1900-2099 was decided only as validation rule. It est, technically DOB must be between 1900-01-01 and 2099-12-31.

gabywh commented 3 years ago

Well, restiction to range 1900-2099 was decided only as validation rule.

sort-of... the regex in the DCC schema is more of a noise filter than anything, the real business rules validation of all the data takes place elsewhere

It est, technically DOB must be between 1900-01-01 and 2099-12-31.

which a year spec of 1900-2099 incorporates, by definition