search

ehn-dcc-development / eu-dcc-schema

Schema for the ehn DCC payload
Apache License 2.0
164 stars 59 forks source link

Digital Green Certificate -> Digital Covid Certificate #81

Closed gabywh closed 3 years ago

gabywh commented 3 years ago

Documentation:

JSON files:

jschlyter commented 3 years ago

Can we please make separate branches for each new feature? Drop next and create a new branch with the relevant commits please. ping @kruzikh @gabywh

jschlyter commented 3 years ago

I've created #82 with changes from @gabywh

gabywh commented 3 years ago

Can we please make separate branches for each new feature? Drop next and create a new branch with the relevant commits please. ping @kruzikh @gabywh

I'm fine with that - was my original proposal anyway. I've only kept to next because that is what people seem to be familiar with here, even though I don't like it and see a lot of issues with working on next. I'll wipe it once these PRs are in

kruzikh commented 3 years ago

Gentlmen, I would need clear guidance how to do it :-) At this moment, I am putting new things and changes into next. How we should do it in the future?

Hynek

On 27. 5. 2021, at 17:13, Gaby Whitehead @.***> wrote:

Can we please make separate branches for each new feature? Drop next and create a new branch with the relevant commits please. ping @kruzikh https://github.com/kruzikh @gabywh https://github.com/gabywh I'm fine with that - was my original proposal anyway. I've only kept to next because that is what people seem to be familiar with here, even though I don't like it and see a lot of issues with working on next. I'll wipe it once these PRs are in

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ehn-digital-green-development/ehn-dgc-schema/pull/81#issuecomment-849717782, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGNB5D4BHIWFPFIQETBGNLLTPZOSVANCNFSM45UIOBEQ.

jschlyter commented 3 years ago

Gentlmen, I would need clear guidance how to do it :-) At this moment, I am putting new things and changes into next. How we should do it in the future?

I've created a separate branch for your changes, please create a PR from that and refrain from using the old next branch.

gabywh commented 3 years ago

Ok for me.

Gentlmen, I would need clear guidance how to do it :-) At this moment, I am putting new things and changes into next. How we should do it in the future?

I've created a separate branch for your changes, please create a PR from that and refrain from using the old next branch.

basically create a branch from main for your feature, sth like:

git checkout -b feature/hynek-new-feature

then do your changes and push that branch (you will probably need git push -u origin feature/hynek-new-feature to create/push to a new branch server-side)