search

ehn-dcc-development / eu-dcc-schema

Schema for the ehn DCC payload
Apache License 2.0
164 stars 59 forks source link

To support DICOM Type 2 for posint values. #89

Closed meneerhenk closed 3 years ago

meneerhenk commented 3 years ago

https://github.com/ehn-digital-green-development/ehn-dgc-schema/pull/new/unknown-value-support

Describes support for DICOM type 2 value solutions. Other fields only specify a maxlen (string) or minimum data in ISO 8601

kruzikh commented 3 years ago

Technicaly maybe, but logically, do we really want to alow non positive entries? I don't see the business need.

ryanbnl commented 3 years ago

You can cover the invariant dose_posint > 0 with a business rule, then you have both correctness and interoperability.

gabywh commented 3 years ago

Discussed at length (again...).

Contention is that the value for standard total doses is available somewhere - thus even in accordance with DICOM Type 2 you still need to supply this value => therefore total doses cannot be zero

A total dose of zero (given the pre-condition that the value for total dose is available - somewhere, somehow) would mean the vaccine has zero standard doses for a full vaccination course which of course means it is never given which means you wouldn't be looking it up in the first place...

Obtaining the value for total dose may be difficult, but it must be recorded somewhere, even if not in the most obvious of places. This is a problem for the Issuance process to resolve (presumably in conjunction with the data management team for the IIS / MIS) and not a problem for the schema per se, as difficult as the value may be to find.

Note that this is qualitatively different to DOB which may not exist at all (or parts thereof).

End of it all: stays as posint for both dose count and total doses, whereby posint starts (by definition) at 1