search

ehn-dcc-development / eu-dcc-schema

Schema for the ehn DCC payload
Apache License 2.0
164 stars 59 forks source link

Examples: add nm to test-rat and updated schema versions to 1.2.1. #93

Closed ryanbnl closed 3 years ago

ryanbnl commented 3 years ago

See #58

gabywh commented 3 years ago

This is a really messy area that has caused a lot of confusion for a lot of people, judging by the constant questions.

Even here:

So, it means that it should NOT include name of the RAT test (that is already included in the valueset).

Should or shall?

The JSON Schema for v1.0.1 defines it like this:

        "nm": {
          "description": "NAA Test Name",
          "type": "string"
        },
        "ma": {
          "description": "RAT Test name and manufacturer",
          "$ref": "https://id.uvci.eu/DGC.ValueSets.schema.json#/$defs/test-manf"
        },

where both nm and ma are optional from a structural JSON schema perspective.

Verification Business Rules will determine via a data-driven approach (what kind of test do we have? which fields do we need for that kind of test?) what is valid.

Summary:

nm field remains in the schema to allow optional sharing information about NAA Test name

... but elsewhere in the eHealthNetwork documentation it was stated as a general principle that all optional-only items have been dropped from the spec, so nm should actually be removed

gabywh commented 3 years ago

closing this one as out-dated wrt v1.3.0