ehn-dcc-development / hcert-kotlin

Kotlin multiplatform implementation of the HCERT/DCC specification
Apache License 2.0
25 stars 25 forks source link

NameNaa type #25

Closed Alival-IT closed 3 years ago

Alival-IT commented 3 years ago

Hello,

is this correct? it seems they should be both type of ValueSetEntryAdapter

    @SerialName("nm")
    val nameNaa: String? = null,

    @SerialName("ma")
    val nameRat: ValueSetEntryAdapter? = null,
Alival-IT commented 3 years ago

ok i see now, feels kinda inconsistent but its correctly implemented

        "nm": {
          "description": "NAA Test Name",
          "type": "string",
          "maxLength": 80
        },
        "ma": {
          "description": "RAT Test name and manufacturer",
          "$ref": "#/$defs/test-manf"
        },