search

ehn-dcc-development / hcert-kotlin

Kotlin multiplatform implementation of the HCERT/DCC specification
Apache License 2.0
25 stars 25 forks source link

JVM library missing public constructors #62

Closed stefan2k closed 2 years ago

stefan2k commented 2 years ago

We use the jvm library in a Java11 project and are missing public constructors for ehn.techiop.hcert.kotlin.chain.impl.TrustListCertificateRepository and ehn.techiop.hcert.kotlin.trust.TrustListDecoderService. Basically we added kotlin-hcert-jvm-1.3.0.jar to pom as well as its dependencies and thats it. Are we missing out on some required steps?

nodh commented 2 years ago

That's highly strange. Did you double check that with 1.3.2? Are you missing other constructors? Because the Java Decompiler seems to show the public constructor: Screenshot_2021-09-27_15-00-22

stefan2k commented 2 years ago

Thank you for looking into this. Yes we did double check with the latest version.

There is a public constructor for TrustListCertificateRepository but not the one mentioned in the projects README. We have to provide a kotlinx.datetime.Clock parameter.

TrustlistDecodeService is the one which has no public constructor at all: grafik

nodh commented 2 years ago

I've looked into the examples from the Readme again, fixed some minor issues, and provided @JvmOverloads for all necessary constructors. Will be included in the next release, thanks for pointing that out.