search

ehn-dcc-development / hcert-kotlin

Kotlin multiplatform implementation of the HCERT/DCC specification
Apache License 2.0
25 stars 25 forks source link

cbor+BigInt and Safari <14 #67

Closed lazka closed 3 years ago

lazka commented 3 years ago

This is more of a heads-up, so feel free to close.

The included cbor library requires BigInt support which is only in Safari 14+

It's not really used when verifying a real HCERT, so I've mocked BigInt during the script import for now, which seems to work fine here and make HCERT validation work with Safari 12.1/13, which is our baseline atm. In case anyone is in a similar situation.

lazka commented 3 years ago

Hm, are you sure that changed anything? bignumber and BigInt are used for different things in cbor from what I can see and I don't think there is a way to make cbor not require BigInt without patching.

I've tested latest main and importing still fails without BigInt.