search

ehn-dcc-development / hcert-schema

Electronic Health Certificates Payload Schema
2 stars 4 forks source link

ISO 3166 Country codes #12

Closed jschlyter closed 3 years ago

jschlyter commented 3 years ago

The schema should clarify if the ISO 3166 country codes are in format alpha-2, alpha-3 or numeric? The current examples mentions "xxx" which indicates alpha-3.

chris2286266 commented 3 years ago

Yes, you are right. I will recheck it with the Semantics document and file a PR later.

martin-lindstrom commented 3 years ago

My vote goes to alpha-2 since we need to use that in the CWT anyway.

Why? The issuer-claim in the CWT will probably be used to find signing certificates, and in a X.509 cert the C RDN normally (always?) has a alpha-2 country code. And there would not be a good idea to mix alpha-2 and alpha-3.

martin-lindstrom commented 3 years ago

And concerning the format of the National Person Identifier. I suggest XX:NUMBER. It's more clear and easier for a human to parse.

jschlyter commented 3 years ago

@chris2286266 please check if {iso3166 alpha-2}:NUMBER is ok

chris2286266 commented 3 years ago

I rechecked it with WG-Semantic document: It comes from HL7, i'm afraid. Source is https://terminology.hl7.org/2.1.0/CodeSystem-v2-0203.html - there it says alpha-3 hmmm ... I's suggest, we leave it as is for the moment. Even if it does not look perfect ...

jschlyter commented 3 years ago

Clarified via ec0d2340ec8f51f9078485aa3c345f2993a9878b