search

ehn-dcc-development / hcert-schema

Electronic Health Certificates Payload Schema
2 stars 4 forks source link

Consider support for schema version draft-7 #13

Closed Razumain closed 3 years ago

Razumain commented 3 years ago

While testing and viewing this schema using my available tools, I discovered that none of them supported the latest schema version 2020-12, used here.

Looking at the current support status: https://json-schema.org/implementations.html

It seems that most (including) my current tool Oxygen, supports up to version draft-7 (http://json-schema.org/draft-07/schema)

The only thing that makes the current schema not compatible with draft-7 is the use of the "example" keyword.

Given the current status, wouldn't it be wise to use draft-7 schema instead in order to allow a wider array of tools? The examples could easily be moved into the descriptive text, even though that is not as nice.

Razumain commented 3 years ago

My bad. I also realise that the keyword minimum is not supported in draft-7. That may be more serious.

Razumain commented 3 years ago

Just in case you are interested in a version compliant with draft-7. Here examples and minimum values are moved to the description instead.

eu_hcert_v1_schema-draft-7.txt

jschlyter commented 3 years ago

I can update the script to render dual JSON-schema versions so we can keep the YAML master as it is.

chris2286266 commented 3 years ago

Yes please @jschlyter

jschlyter commented 3 years ago

Fixed.