search

ehoogerbeets / conjugator

Conjugate verbs in Spanish
Apache License 2.0
23 stars 6 forks source link

Errors in conjugations (files verbsIE.tsv and verbsEIE.tsv aren't used) #2

Open brunocuervo opened 6 years ago

brunocuervo commented 6 years ago

Verbs included in verbsIE.tsv and verbsEIE.tsv are (mostly) wrongly conjugated: e.g. acertar, encender, mantener in the former, competir in the latter. Only verbs like tener, which is included in exceptions.json, are correct. Is this expected?

There's no code in inflect.js reading the columns and applying the necessary corrections (replacing e with ie, using the yo column where appropriate, etc). I guess it's probably too much to add to them all to exceptions.json.

ehoogerbeets commented 6 years ago

Hi Bruno, I have added you as a collaborator. Fix is here if you'd like to review it:

https://github.com/ehoogerbeets/conjugator/pull/4

brunocuervo commented 6 years ago

Hi Edwin, sorry for the delay: I've been meaning to take a look at this but haven't had time until now. It looks much better! But now there's a problem with the new logic added in line 340 of inflect.js: searching for exceptions in this way breaks a lot of regular verbs. E.g: agrandar, defraudar or aguardar should't follow dar's conjugation. The same happens for example with apestar or arrestar following estar. How would you like to handle this?