search

ehough / docker-nfs-server

A lightweight, robust, flexible, and containerized NFS server.
https://hub.docker.com/r/erichough/nfs-server/
GNU General Public License v3.0
672 stars 221 forks source link

Dockerfile: use alpine:3.9 #16

Closed macpijan closed 5 years ago

macpijan commented 5 years ago

Alpine 3.9 privides the nfs-utils 2.3.2-r1. I have tested the basic functionality and it works just fine for me. Fixes the https://github.com/ehough/docker-nfs-server/issues/15

Signed-off-by: Maciej Pijanowski maciej.pijanowski@3mdeb.com

ehough commented 5 years ago

Thank you for this PR! I'm going to respectfully decline it because alpine:latest and alpine:3.9 are the same.

The good news is that I believe we are finally ready to fully switch over to Alpine. I'll post an update on #15 right now. Stand by for that, and thank you again for the PR.

macpijan commented 5 years ago

That's correct. They are the same at the moment. I just prefer to always state the base image exact version rather than latest and upgrade it to the next version when I feel necessary. But it's totally up to you here. Thanks for the repo BTW. I've been inspecting several NFS containers today and liked yours the most :+1:

ehough commented 5 years ago

Appreciate the kind words and glad to hear you're getting good use out of the image!

I'll be checking out your other PR later today. Thanks!