search

ehough / docker-nfs-server

A lightweight, robust, flexible, and containerized NFS server.
https://hub.docker.com/r/erichough/nfs-server/
GNU General Public License v3.0
672 stars 221 forks source link

feature: ARM support #34

Open ehough opened 4 years ago

ehough commented 4 years ago

Currently the image is only built for x86-64. We should build an ARM-based image that can run on, for example, Raspberry Pi.

testautomation commented 4 years ago

subscribed :)

flavioschuindt commented 4 years ago

Hey @ehough, I've implemented this. Just tested and it's working super fine on my raspberry: https://hub.docker.com/repository/docker/fschuindt/docker-nfs-server

Note that it's entirely based on yours and I was thinking initially to actually fork your repo and submit a PR. However, since last year, Docker for Desktop offers a nice feature called buildx. This means that from a single Dockerfile, I can from my amd64 computer, cross build it to different archs. You can read more about it here. With this in mind, I just cloned your repo and following the link, I could successfully generate a new image and pushed to my own repo with no changes in the original Dockerfile in this repo.

Let me know how you wanna handle this. Ideally, you could follow the link and add instructions on the README so people can cross build it. After this, you can start rebuilding this to your own repo on docker hub and then everyone will have multi arch support. I can help with the README, just let me know the best approach as you control the repo here.

pramitbiswas commented 10 months ago

@flavioschuindt your link is not accessible without login to the docker hub. Can you please check that? You can also add a PR for the same.