search

ehpc / bootstrap-waitingfor

"Waiting for..." modal dialog with progress bar for Bootstrap
MIT License
138 stars 82 forks source link

Adding support for Bootstrap 4 #25

Closed falkdav closed 6 years ago

falkdav commented 6 years ago

Hello, first off, nice plugin!

I want to know if would be possible to add support for Bootstrap 4 to this cool plugin.

Thanks!

ehpc commented 6 years ago

Hi, @falkdav! Thanks. Yeah sure, I'll try to test it in a couple of days.

Lion-HC commented 6 years ago

My temporary circumvention:

define(['../lib/bootstrap-waitingfor/src/waitingfor'], function (waitingDialog) { var oldShow = waitingDialog.show; waitingDialog.show = function (message, options){ if (!options) { options = {}; } if (options.progressType) { options.progressType += ' progress-bar-striped progress-bar-animated'; } else { options.progressType = 'striped progress-bar-animated'; } oldShow(message, options); }; return waitingDialog; });

falkdav commented 6 years ago

Hi @Lion-HC where should I put that code?

Lion-HC commented 6 years ago

It's something like wrapper for waitingfor to support bootstrap4. It's if you using AMD (require.js) If not - you can override waitingDialog.show somewhere globally before using it.

ehpc commented 6 years ago

Fixed with https://github.com/ehpc/bootstrap-waitingfor/pull/26