ehpor / hcipy

A framework for performing optical propagation simulations, meant for high contrast imaging, in Python.
https://hcipy.org
MIT License
91 stars 30 forks source link

Feature/knife edge directions #142

Closed syhaffert closed 2 years ago

syhaffert commented 2 years ago

The Knife Edge coronagraph for multiple directions. A test has been added to check all directions and knife edge offsets.

codecov[bot] commented 2 years ago

Codecov Report

Merging #142 (4af8dbe) into master (058c473) will increase coverage by 1.04%. The diff coverage is 97.26%.

:exclamation: Current head 4af8dbe differs from pull request most recent head 2f60830. Consider uploading reports for the commit 2f60830 to get more accurate results

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
+ Coverage   79.57%   80.62%   +1.04%     
==========================================
  Files          94       94              
  Lines        6503     6848     +345     
==========================================
+ Hits         5175     5521     +346     
+ Misses       1328     1327       -1     
Impacted Files Coverage Δ
hcipy/aperture/__init__.py 100.00% <ø> (ø)
hcipy/optics/detector.py 72.46% <ø> (+0.82%) :arrow_up:
hcipy/version.py 83.33% <81.81%> (+5.55%) :arrow_up:
hcipy/field/coordinates.py 76.84% <92.85%> (+3.59%) :arrow_up:
hcipy/aperture/realistic.py 96.56% <98.50%> (+0.60%) :arrow_up:
hcipy/aperture/generic.py 93.15% <100.00%> (+0.50%) :arrow_up:
hcipy/config/config.py 87.87% <100.00%> (+1.51%) :arrow_up:
hcipy/field/grid.py 81.31% <100.00%> (+2.83%) :arrow_up:
hcipy/fourier/fast_fourier_transform.py 96.17% <100.00%> (+0.04%) :arrow_up:
hcipy/fourier/fourier_transform.py 93.06% <100.00%> (ø)
... and 36 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

syhaffert commented 2 years ago

This branch is failing on the windows pickle bug. I will need to rebase this PR.